Jkmarx/group name duplicate error (#1573)

* Error handling in the group api.

* Prevent duplicate group names.

* Fix name duplication check.

* Double quote strings.

* Remove duplicate error since db returns integrityError.

* Create and call clean method for stripping white spaces.

* Utilize full_clean for param validation.

* Remove unnessary methods due to using full_clean.

refinery/core/api.py

@@ -21,6 +21,7 @@
 from django.template import loader, Context
 from django.core.cache import cache
 from django.core.signing import Signer
+from django.forms import ValidationError
 from guardian.shortcuts import get_objects_for_user, get_objects_for_group
 from guardian.models import GroupObjectPermission
 from tastypie import fields
@@ -2018,6 +2019,14 @@ def obj_create(self, bundle, **kwargs):
         user = bundle.request.user
         data = json.loads(bundle.request.body)
         new_ext_group = ExtendedGroup(name=data['name'])
+
+        new_ext_group.name = new_ext_group.name.strip()
+        try:
+            new_ext_group.full_clean()
+        except ValidationError as e:
+            raise ImmediateHttpResponse(HttpBadRequest(
+                'Invalid group creation request: %s.' % e
+            ))
         new_ext_group.save()
         new_ext_group.user_set.add(user)
         new_ext_group.manager_group.user_set.add(user)

refinery/core/models.py

@@ -1872,13 +1872,6 @@ def get_managed_group(self):
         except:
             return None
 
-    def save(self, *args, **kwargs):
-        if len(self.name) == 0:
-            logger.error("Group name cannot be empty.")
-            return
-        else:
-            super(ExtendedGroup, self).save(*args, **kwargs)
-
 
 # automatic creation of a managed group when an extended group is created:
 def create_manager_group(sender, instance, created, **kwargs):