Scottx611x/selenium bug fix (#1795)

* Bump geckdriver version

* Bump pytest-selenium and selenium versions for compat. w/ geckodriver

* update puppet-archive to latest version

* Value is already a default

* Don't specify `creates` so that new versions of geckodriver install properly

* Bump firefox version

* Pull latest `firefox` package like we are doing in Puppet

* Specifying firefox package didn't work

* specifying `firefox` package alone didn't pull one that was recent enough

.travis.yml

@@ -2,7 +2,7 @@ sudo: required
 language: python
 cache: pip
 addons:
-  firefox: "49.0.1"
+  firefox: "53.0.3"
   apt:
     packages:
       - xvfb
@@ -17,7 +17,7 @@ services:
 install:
   - pip install -r requirements.txt --quiet
   # Install geckodriver required for selenium testing
-  - GECKODRIVER_VERSION=v0.15.0
+  - GECKODRIVER_VERSION=v0.17.0
   - TAR=geckodriver-$GECKODRIVER_VERSION-linux64.tar
   - wget https://github.com/mozilla/geckodriver/releases/download/$GECKODRIVER_VERSION/$TAR.gz
   - gunzip $TAR.gz

deployment/Puppetfile

@@ -9,7 +9,7 @@ mod 'puppetlabs/lvm', '0.7.0'
 mod 'puppetlabs/postgresql', '4.9.0'
 mod 'puppetlabs/rabbitmq', '5.6.0'
 mod 'puppetlabs/stdlib', '4.13.1'
-mod 'puppet-archive', '1.2.0'
+mod 'puppet-archive', '1.3.0'
 mod 'saz/timezone', '3.2.0'
 mod 'stankevich/python', '1.9.8'
 mod 'thias/sysctl', '1.0.2'

deployment/refinery-modules/refinery/manifests/selenium.pp

@@ -1,5 +1,5 @@
 class refinery::selenium {
-  $geckodriver_version = 'v0.15.0'
+  $geckodriver_version = 'v0.17.0'
   $filename = "geckodriver-${geckodriver_version}-linux64.tar.gz"
   $install_path = "/opt/geckodriver"
 
@@ -11,10 +11,8 @@
     source     => "https://github.com/mozilla/geckodriver/releases/download/$geckodriver_version/$filename",
     extract       => true,
     extract_path  => '/opt/',
-    creates       => $install_path,
     user        => 'root',
     group       => 'root',
-    cleanup       => 'true',
   }
   ->
   file { '/usr/bin/geckodriver':

requirements.txt

@@ -58,7 +58,7 @@ Pygments==1.6rc1
 pyOpenSSL==16.2.0
 pysam==0.9.1.4
 pysolr==3.3.2
-pytest-selenium==1.9.1
+pytest-selenium==1.10.0
 python-ldap==2.4.19
 python-magic==0.4.6
 python-memcached==1.57
@@ -67,7 +67,7 @@ PyYAML==3.11
 pyvirtualdisplay==0.2.1
 readline==6.2.2
 requests==2.7.0
-selenium==3.3.0
+selenium==3.4.0
 six==1.10.0
 sqlparse==0.1.19
 supervisor==3.1.3