Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load third-party UI dependencies in static via bower #1016

Closed
flekschas opened this issue Apr 15, 2016 · 3 comments
Closed

Load third-party UI dependencies in static via bower #1016

flekschas opened this issue Apr 15, 2016 · 3 comments
Assignees
@jkmarx
Labels
client core technical debt

Comments

@flekschas
Copy link
Member

Commit: df3ad33

Steps to reproduce

  1. Go to /refinery/static/source/

Observed behavior

You'll find:

  • backbone
  • bootbox
  • d3
  • ...

Expected behavior

Bower should load these dependencies.
@flekschas flekschas self-assigned this Apr 15, 2016
@flekschas flekschas added this to the Next milestone Apr 15, 2016
@mccalluc
Copy link
Member

mccalluc commented Aug 5, 2016

#1016

@jkmarx jkmarx removed this from the Next milestone Oct 20, 2016
@jkmarx jkmarx assigned jkmarx and unassigned flekschas Nov 10, 2016
@jkmarx
Copy link
Member

jkmarx commented Nov 10, 2016

This issue will go away with the implementation of the data-set2 browser and the removal of the data set1 browser code.

@jkmarx
Copy link
Member

jkmarx commented Jan 6, 2017

With data set 2, most of the libraries will either be no longer used or are being imported via bower.

@jkmarx jkmarx closed this as completed Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkmarx jkmarx

Labels
client core technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mccalluc @flekschas @jkmarx