Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut not validated for being alphanumeric + "_" #1395

Closed
mccalluc opened this issue Sep 9, 2016 · 1 comment · Fixed by #1441
Closed

Shortcut not validated for being alphanumeric + "_" #1395

mccalluc opened this issue Sep 9, 2016 · 1 comment · Fixed by #1441
Assignees
@jkmarx
Labels
enhancement ui
Milestone
v1.5.0

Comments

@mccalluc
Copy link
Member

mccalluc commented Sep 9, 2016

Commit: fca97c9

Steps to reproduce

  1. Upload data
  2. In the public shortcut field, include an invalid character

Observed behavior

  1. No error: The bad string seems to have been saved:

screen shot 2016-09-09 at 11 38 30 am

### Expected behavior 1. Input validation error: The user may not continue until it is corrected.
@mccalluc mccalluc added this to the Next milestone Sep 9, 2016
@mccalluc mccalluc changed the title Shortcut not validated for being alphanumeric Shortcut not validated for being alphanumeric + "_" Sep 9, 2016
@hackdna hackdna modified the milestones: v1.5.0, Next Sep 21, 2016
@hackdna
Copy link
Member

hackdna commented Sep 21, 2016

data set sharing / collaboration

@jkmarx jkmarx self-assigned this Sep 29, 2016
@jkmarx jkmarx mentioned this issue Sep 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkmarx jkmarx

Labels
enhancement ui
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Jkmarx/data import slug validation refinery-platform/refinery-platform
3 participants
@hackdna @mccalluc @jkmarx