Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Failed Unit Test, Locally #1427

Closed
jkmarx opened this issue Sep 26, 2016 · 2 comments
Closed

UI - Failed Unit Test, Locally #1427

jkmarx opened this issue Sep 26, 2016 · 2 comments
Assignees
Milestone

Comments

@jkmarx
Copy link
Member

jkmarx commented Sep 26, 2016

  • Specific code commit: 601615c
  • Version of the web browser and OS: Chrome 53.0.2785.89
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance):
    Dev mode

Steps to reproduce

Please list all the actions and the input data used:

  1. Switch to develop
  2. Run grunt test

Observed behavior

Travis builds are passing.
Locally:

Running "karma:unit" (karma) task
26 09 2016 10:02:19.582:INFO [karma]: Karma v0.13.22 server started at http://localhost:9999/
26 09 2016 10:02:19.606:INFO [launcher]: Starting browser PhantomJS
26 09 2016 10:02:20.567:INFO [PhantomJS 2.1.1 (Linux 0.0.0)]: Connected on socket /#qTTkRYVpnAKQvlHJAAAA with id 12769061
PhantomJS 2.1.1 (Linux 0.0.0): Executed 136 of 460 SUCCESS (0 secs / 0.579 secs)
PhantomJS 2.1.1 (Linux 0.0.0) DataSetImport.directive.isaTabImport: unit tests DOM should replace custom element with template FAILED
        Expected 'dataUploadTutorialStep6' to be 'isa-tab-import-form'.
        /vagrant/refinery/ui/source/js/data-set-import/directives/isa-tab-import.spec.js:37:42
PhantomJS 2.1.1 (Linux 0.0.0): Executed 460 of 460 (1 FAILED) (2.574 secs / 1.923 secs)
Warning: Task "karma:unit" failed. Use --force to continue.
Aborted due to warnings.

Expected behavior

When local grunt tests fail, travis builds should fail.

@mccalluc
Copy link
Member

When adding the selenium tests, I changed grunt to grunt make: I don't know why. @scottx611x has fixed the the UI test, and in the same PR is fixing travis.

@scottx611x
Copy link
Member

scottx611x commented Sep 26, 2016

This has been addressed as of commit: 276ab58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants