Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in pop-overs are un-clickable #1886

Closed
mccalluc opened this issue Jul 10, 2017 · 4 comments
Closed

Links in pop-overs are un-clickable #1886

mccalluc opened this issue Jul 10, 2017 · 4 comments

Comments

@mccalluc
Copy link
Member

mccalluc commented Jul 10, 2017

  • Specific code commit: bc425b3
  • Version of the web browser and OS: both ff and chrome, macos
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): production, test instance

Steps to reproduce

Please list all the actions and the input data used:

  1. On the dashboard, click on dataset you own to get a preview to fold out
  2. Click on "share" above the right pane: This brings up "Permission Editor"
  3. Click on the question mark to bring up the "Share a Data Set" popover
  4. Click on a link in the popover

or, in file-upload

  1. click on the "?" for " Column containing species names or identifiers."

Observed behavior

  • The popover closes, rather than taking you to the appropriate resource

Expected behavior

  • Links take you to the appropriate pages... but maybe it'd be easier just not to have links here?

(Should also review other pop-overs to see if they contain links, and if they are clickable.)

@mccalluc mccalluc changed the title Links in "Permission Editor" pop-over are un-clickable Links in pop-overs are un-clickable Jul 10, 2017
@scottx611x
Copy link
Member

Unable to reproduce. @mccalluc will check it out again with other browsers.

@jkmarx jkmarx self-assigned this Oct 10, 2017
@jkmarx jkmarx added this to the Release 1.6.1 milestone Oct 10, 2017
@jkmarx
Copy link
Member

jkmarx commented Oct 13, 2017

I encountered this issue when updating the global analysis popover. The append-to-body option was required, but note, it will move the popover scope out of the parent's scope. I'll double check the permission editor and either fix it or close this issue.

@jkmarx
Copy link
Member

jkmarx commented Oct 13, 2017

I checked the permission editor and any popover-html references. I could not reproduce this issue in chrome, firefox, or safari. @mccalluc If you reproduce, please make a giphy and reopen the issue.

@jkmarx
Copy link
Member

jkmarx commented Oct 13, 2017

Reference #2231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants