Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Set summary is exposed on private sets even with no login #1888

Closed
mccalluc opened this issue Jul 10, 2017 · 1 comment
Closed

Data Set summary is exposed on private sets even with no login #1888

mccalluc opened this issue Jul 10, 2017 · 1 comment

Comments

@mccalluc
Copy link
Member

mccalluc commented Jul 10, 2017

  • Specific code commit: bc425b3
  • Version of the web browser and OS: FF MacOS
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): Production

Steps to reproduce

Please list all the actions and the input data used:

  1. Login, and identify an unshared data set.
  2. Click on it to get a preview URL
  3. Log out, and then load that same URL

Observed behavior

  • The Preview will load, though with nothing highlighted on the left.

Expected behavior

  • Not sure: Maybe this is intentional, or maybe we're leaking information which should be private? If this is not the desired behavior, I'm not sure what is... Maybe a 404-equivalent only on the right-hand side?
@mccalluc mccalluc removed the question label Aug 1, 2017
@jkmarx jkmarx added this to the Next milestone Oct 27, 2017
@jkmarx jkmarx self-assigned this Mar 14, 2018
@jkmarx jkmarx modified the milestones: Next, Release 1.6.3, Release 1.6.4 Mar 20, 2018
@jkmarx jkmarx added this to Doing in JM Tasks 1.6.6 Mar 26, 2018
@jkmarx jkmarx moved this from Doing to Planning/Not Started in JM Tasks 1.6.6 Mar 26, 2018
@jkmarx jkmarx modified the milestones: Release 1.6.4, Next Apr 30, 2018
@jkmarx jkmarx modified the milestones: Release 1.6.4, Next May 10, 2018
@jkmarx jkmarx modified the milestones: Next, Release 1.6.6 Jul 27, 2018
@jkmarx jkmarx removed this from Planning/Not Started in JM Tasks 1.6.6 Jul 31, 2018
@jkmarx jkmarx added this to Planning/Not Started in JM Tasks 1.6.6 Jul 31, 2018
@jkmarx jkmarx moved this from Planning/Not Started to Doing in JM Tasks 1.6.6 Aug 8, 2018
@jkmarx jkmarx removed the important label Aug 9, 2018
@jkmarx jkmarx removed this from the Release 1.6.6 milestone Aug 9, 2018
@jkmarx jkmarx moved this from Doing to Stalled for Feedback in JM Tasks 1.6.6 Aug 13, 2018
@jkmarx jkmarx removed this from Stalled for Feedback in JM Tasks 1.6.6 Aug 13, 2018
@jkmarx
Copy link
Member

jkmarx commented Mar 7, 2019

With v1.6.9 Explore/Satori has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants