Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satori treemap labels not being cleaned up on redraw #1908

Closed
mccalluc opened this issue Jul 13, 2017 · 0 comments
Closed

Satori treemap labels not being cleaned up on redraw #1908

mccalluc opened this issue Jul 13, 2017 · 0 comments

Comments

@mccalluc
Copy link
Member

  • Specific code commit: 58aa066
  • Version of the web browser and OS: MacOS FF
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): Test Production

Steps to reproduce

I do not have a reliable reproducer. I saw this after bringing up an old window first thing in the morning, and dragging it between monitors, which seems to prompt a redraw.

Observed behavior

(At first there was only one extra copy of each label, but they seem to be multiplying.
screen shot 2017-07-13 at 9 13 07 am

In the console I see this error:

Error: this.children[(this.visibleDepth + 1)] is undefined
i.prototype.removeLevelsOfNodes@https://refinery-static.s3.amazonaws.com/js/commons.js:4:15246
i.prototype.adjustLevelDepth@https://refinery-static.s3.amazonaws.com/js/commons.js:4:9854
set/<@https://refinery-static.s3.amazonaws.com/js/commons.js:4:20883
f/q<@https://refinery-static.s3.amazonaws.com/vendor/angular/angular.min.js:160:50
e@https://refinery-static.s3.amazonaws.com/vendor/angular/angular.min.js:45:485
og/k.defer/c<@https://refinery-static.s3.amazonaws.com/vendor/angular/angular.min.js:48:414

And here's the inner-html of the treemap:
tree-map.txt

Expected behavior

  • Labels should not be repeated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants