Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old file browser is broken #2083

Closed
mccalluc opened this issue Sep 5, 2017 · 6 comments
Closed

Old file browser is broken #2083

mccalluc opened this issue Sep 5, 2017 · 6 comments
Labels
Milestone

Comments

@mccalluc
Copy link
Member

mccalluc commented Sep 5, 2017

This page needs to hang around for the provenance visualization, and other functionality will be removed, gradually, but it seems broken right now.

@mccalluc mccalluc added this to the Release 1.6.0 milestone Sep 5, 2017
@mccalluc mccalluc added the bug label Sep 5, 2017
@mccalluc
Copy link
Member Author

mccalluc commented Sep 6, 2017

Doing a binary search through the history: provenance was introduced at 61ebee1, and that works when I check it out.

@mccalluc
Copy link
Member Author

mccalluc commented Sep 6, 2017

Works at a679b99, broken at 97af506 -> My PR #2061 is at fault.

@mccalluc
Copy link
Member Author

mccalluc commented Sep 6, 2017

Looking at commits within that PR, I'm not convinced it has ever worked after the rename. The behavior at 75a4d4a (where the rename is completed) matches the behavior at c8d8f77 (end of the pr). It's possible I had done supervisorctl restarts but not grunt build and didn't realize it wasn't working?

@mccalluc
Copy link
Member Author

mccalluc commented Sep 6, 2017

Angular routing is confused: going to data-set-ui-mode-browse.html, which is just

<!-- Nothing here -->

Simply removing that state from data-set-nav.js causes an Infinite $digest Loop error from Angular.

@mccalluc
Copy link
Member Author

mccalluc commented Sep 8, 2017

There are no links to provenance right now (#2096), so it's not a high priority for this milestone.

@scottx611x
Copy link
Member

closed by #2179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants