Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-dataset browser: genotype facets max out at 100? #2148

Closed
mccalluc opened this issue Sep 14, 2017 · 4 comments
Closed

Cross-dataset browser: genotype facets max out at 100? #2148

mccalluc opened this issue Sep 14, 2017 · 4 comments
Assignees

Comments

@mccalluc
Copy link
Member

mccalluc commented Sep 14, 2017

  • Specific code commit: 2a3c825
  • Version of the web browser and OS: ff macos
  • Environment where the error occurred: test production

Steps to reproduce

https://test.stemcellcommons.org/files/

Looks at the genotype facets.

Observed behavior

  • Only 100 values are given ... probably a limit in solr ... but if we did bump the limit up, would that even be usable?
    screen shot 2017-09-14 at 12 03 04 pm
@jkmarx
Copy link
Member

jkmarx commented Feb 22, 2018

@jkmarx Discuss with @gmnelson

@jkmarx
Copy link
Member

jkmarx commented Feb 22, 2018

@sjhosui

@gmnelson
Copy link
Contributor

@jkmarx If there is a limit, it must now be > 100:

image

I would say list as many facets as exist for an attribute, particularly since we offer sorting by counts and searching by keyword.

In fact, in case a limit does still exist, does that mean that facets that are not shown are also not accessible by keyword search? If this would be the case, I would argue even more strongly for showing everything.

@jkmarx jkmarx removed the question label Feb 22, 2018
@jkmarx
Copy link
Member

jkmarx commented Jul 24, 2018

I'm closing, there doesn't appear to be a limit.
screen shot 2018-07-24 at 10 32 45 am

@jkmarx jkmarx closed this as completed Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants