Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Provenance, dynamically loaded JS 404s #2341

Closed
mccalluc opened this issue Nov 8, 2017 · 2 comments
Closed

On Provenance, dynamically loaded JS 404s #2341

mccalluc opened this issue Nov 8, 2017 · 2 comments

Comments

@mccalluc
Copy link
Member

mccalluc commented Nov 8, 2017

  • Specific code commit: 09a2aa2
  • Version of the web browser and OS: Any
  • Environment where the error occurred: Prod test

Steps to reproduce

  1. Try to bring up the Provenance tab

Observed behavior

It just spins: JS console reports a syntax error on unexpected '<'. Network logs show lots of 404s:

https://test.stemcellcommons.org/static/js/
.../refinery/contents.js?_=1510159952098
.../provis/provvis-helpers.js?_=1510159952099
.../provis/provvis-decl.js?_=1510159952100
.../provis/provvis-init.js?_=1510159952101
.../provis/provvis-layout.js?_=1510159952102
.../provis/provvis-motifs.js?_=1510159952103
.../provis/provvis-render.js?_=1510159952104

We should be getting static assets from s3, so maybe the helper method isn't being used here?

Expected behavior

  • Provenance loads
@jkmarx
Copy link
Member

jkmarx commented Nov 8, 2017

I know the issue. 'static' url was hardcoded and not using the dynamically generate method. Will create a hot fix. @mccalluc

@scottx611x
Copy link
Member

Fixed by #2347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants