Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Import into own space" should only be available for ISAtabs #2519

Open
mccalluc opened this issue Jan 19, 2018 · 4 comments
Open

"Import into own space" should only be available for ISAtabs #2519

mccalluc opened this issue Jan 19, 2018 · 4 comments

Comments

@mccalluc
Copy link
Member

  • Specific code commit: 8b2625a
  • Version of the web browser and OS: Mac FF
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): Prod Test

Steps to reproduce

Please list all the actions and the input data used:

  1. I'm on https://test.stemcellcommons.org/data_sets/7031a25c-9c2d-4e1e-b20d-443c7638bcea/#/about/, which is a CSV data set which I own.
  2. There is a "Import into own space" button.

Expected behavior

The button shouldn't be there: There is nothing in the metadata section, so this is not a ISATab, I believe.

(See also #2518)

@jkmarx
Copy link
Member

jkmarx commented Jan 23, 2018

This is an issue on the file browser.

@hackdna hackdna added this to To do in Data set management via automation Jan 31, 2018
@jkmarx jkmarx added this to the Release 1.6.3 milestone Mar 21, 2018
@hackdna hackdna moved this from To do to Done in Data set management Jun 11, 2018
@jkmarx jkmarx reopened this Sep 12, 2019
Data set management automation moved this from Done to To do Sep 12, 2019
@jkmarx jkmarx modified the milestones: Release 1.6.3, Release 1.7.1 Sep 12, 2019
@jkmarx jkmarx self-assigned this Sep 12, 2019
@jkmarx
Copy link
Member

jkmarx commented Sep 12, 2019

@ilan-gold fyi

@ilan-gold
Copy link
Member

Using elaine-metadata.tsv (github wont let me upload :( it's on the hsci site), i got the following by logging in as an admin, uploading, changing permissions to be for public, and then logging in as guest and clicking through to it:

Screen Shot 2019-09-18 at 8 59 11 AM

Screen Shot 2019-09-18 at 8 59 15 AM

@jkmarx
Copy link
Member

jkmarx commented Sep 18, 2019

Need to follow-up. This data set has a pre_isa_archive_uuid and a file_store_item.datafile, but is not an isatab. Thoughts on how to distinguish isatabs further?

@ngehlenborg ngehlenborg removed this from the Release 1.7.1 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants