Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default not to list static assets s3 bucket contents? #2762

Closed
mccalluc opened this issue May 14, 2018 · 1 comment
Closed

Default not to list static assets s3 bucket contents? #2762

mccalluc opened this issue May 14, 2018 · 1 comment
Assignees
@hackdna
Labels
bug deployment
Projects
AWS S3 as a storage backend
Milestone
Release 1.6.7

Comments

@mccalluc
Copy link
Member

  • Specific code commit: 61bd4db
  • Version of the web browser and OS: FF on Mac
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): Testing production

Steps to reproduce

  1. https://release-1-6-4-static.s3.amazonaws.com/ returns an xml listing of the contents... (Got here trying to debug an badly formatted error page.) I don't know that this is doing us any harm, but there is no good reason to expose that listing: better to return 4xx than a very large 200?
@mccalluc mccalluc changed the title Default not to list s3 bucket contents? Default not to list static assets s3 bucket contents? May 14, 2018
@hackdna
Copy link
Member

hackdna commented May 22, 2018

All content in that bucket is public. XML listing is 232KB.

@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Oct 23, 2018
@hackdna hackdna mentioned this issue Oct 23, 2018
Merged
@hackdna hackdna added this to the Release 1.6.7 milestone Oct 23, 2018
@hackdna hackdna self-assigned this Oct 23, 2018
@hackdna hackdna moved this from In Progress to QA in AWS S3 as a storage backend Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackdna hackdna

Labels
bug deployment
Projects
AWS S3 as a storage backend
QA
Milestone
Release 1.6.7
Development

No branches or pull requests
2 participants
@hackdna @mccalluc