Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node functionality is split between core and data_set_manager #2837

Closed
hackdna opened this issue Jun 26, 2018 · 3 comments
Closed

Node functionality is split between core and data_set_manager #2837

hackdna opened this issue Jun 26, 2018 · 3 comments

Comments

@hackdna
Copy link
Member

hackdna commented Jun 26, 2018

This violates Django design principles and makes the code difficult to understand and maintain.

@jkmarx
Copy link
Member

jkmarx commented Jul 6, 2018

It should go in data_set_manager? @hackdna @scottx611x

@scottx611x
Copy link
Member

@jkmarx I would say so. It would be much tougher to move the model/migrations into core/

@hackdna
Copy link
Member Author

hackdna commented Jul 13, 2018

Also, core Django app should be reduced in size and ideally, just be used for bit and pieces that don't belong to any particular app (Two Scoops 29.1).

@jkmarx jkmarx modified the milestones: Next, Release 1.6.6 Jul 27, 2018
@jkmarx jkmarx self-assigned this Jul 27, 2018
Technical Debt automation moved this from Backlog to Done Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants