Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/move node related to data set manager #2911

Merged
merged 4 commits into from Jul 27, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jul 27, 2018

Resolves #2837

  • Node related code was moved from the core module to the data_set_manager. (No new code was introduced.)
  • API V1, API V2, Serializer, API V1 Unit tests
  • API V2 Unit test will be written in a separate pull request.

@jkmarx jkmarx self-assigned this Jul 27, 2018
@jkmarx jkmarx requested a review from scottx611x July 27, 2018 17:37
@jkmarx jkmarx added this to the Release 1.6.6 milestone Jul 27, 2018
@codecov
Copy link

codecov bot commented Jul 27, 2018

Codecov Report

Merging #2911 into develop will decrease coverage by 0.14%.
The diff coverage is 60.67%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2911      +/-   ##
===========================================
- Coverage    59.33%   59.19%   -0.15%     
===========================================
  Files          435      435              
  Lines        28180    27227     -953     
  Branches      1273     1273              
===========================================
- Hits         16721    16116     -605     
+ Misses       11459    11111     -348
Impacted Files Coverage Δ
refinery/core/urls.py 100% <ø> (ø) ⬆️
refinery/data_set_manager/urls.py 100% <ø> (ø) ⬆️
refinery/core/serializers.py 84.93% <ø> (+1.89%) ⬆️
refinery/core/api.py 39.24% <100%> (-1.16%) ⬇️
refinery/core/test_api.py 99.16% <100%> (-0.55%) ⬇️
refinery/core/views.py 41.94% <100%> (-2.49%) ⬇️
refinery/data_set_manager/serializers.py 100% <100%> (ø) ⬆️
refinery/data_set_manager/views.py 56.47% <23.07%> (-5.15%) ⬇️
refinery/data_set_manager/api.py 95.37% <87.5%> (-2.58%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878e5f2...3864d6e. Read the comment docs.

@scottx611x scottx611x merged commit 6c8144c into develop Jul 27, 2018
@scottx611x scottx611x deleted the jkmarx/move-node-related-to-data_set_manager branch July 27, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants