Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileBrowser add file functionality fails if DataSet's sources haven't been translated to their corresponding s3 upload buckets #2887

Closed
scottx611x opened this issue Jul 18, 2018 · 1 comment

Comments

@scottx611x
Copy link
Member

  • Specific code commit: 4d61e10
  • Version of the web browser and OS: N/A
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): test.stemcellcommons.org

Steps to reproduce

Please list all the actions and the input data used:

  • Upload a dataset: (hg19-metadata-local.txt) and import at least one of its corresponding datafiles (s5_p42_E2_45min.subsample.fastq) as part of the import process.
  • Notice that all of the DataSet's FileStoreItem's sources will get mapped from /data/import/... to their new s3://release-1-6-5-testing-upload/..... ones once they get a file_source_translator from generate_file_source_translator() during the metadata parsing phase.
  • You can then properly use the add files functionality from the FileBrowser UI for all Nodes in the DataSet.

Observed behavior

  • If you upload the same DataSet without importing any data files, the FileStoreItem sources will remain "untranslated" (/data/import/...) and you won't be able to add any files from the FileBrowser UI.
  • It would be up to AddFileToNodeView and the .js that POSTs to it to do the file source translation and sending over of the Cognito identity_id, respectively.

Expected behavior

  • To be able to add data files in the FileBrowser UI when this edge case occurs
@scottx611x scottx611x added this to the Release 1.6.5 milestone Jul 18, 2018
@scottx611x scottx611x self-assigned this Jul 18, 2018
@scottx611x scottx611x added this to Backlog in Scott O. Tasks via automation Jul 19, 2018
@scottx611x scottx611x moved this from Backlog to Doing in Scott O. Tasks Jul 19, 2018
@scottx611x scottx611x moved this from Doing to Done in Scott O. Tasks Jul 19, 2018
@scottx611x
Copy link
Member Author

Closed in #2890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant