New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scottx611x/fix add file source translation #2890
Merged
scottx611x
merged 9 commits into
release-1.6.5
from
scottx611x/fix_add_file_source_translation
Jul 19, 2018
Merged
Scottx611x/fix add file source translation #2890
scottx611x
merged 9 commits into
release-1.6.5
from
scottx611x/fix_add_file_source_translation
Jul 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in AddFileToNodeView
`generate_file_source_translator()` will do the rest, but won't work properly with an absolute path in this case
…all deployment platforms
Codecov Report
@@ Coverage Diff @@
## release-1.6.5 #2890 +/- ##
=================================================
- Coverage 59.48% 59.16% -0.33%
=================================================
Files 434 434
Lines 27603 27189 -414
Branches 1274 1268 -6
=================================================
- Hits 16421 16086 -335
+ Misses 11182 11103 -79
Continue to review full report at Codecov.
|
…sources can be translated
jkmarx
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2887