Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scottx611x/fix add file source translation #2890

Merged
merged 9 commits into from Jul 19, 2018

Conversation

scottx611x
Copy link
Member

@scottx611x scottx611x commented Jul 19, 2018

Fix #2887

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #2890 into release-1.6.5 will decrease coverage by 0.32%.
The diff coverage is 98.36%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.6.5    #2890      +/-   ##
=================================================
- Coverage          59.48%   59.16%   -0.33%     
=================================================
  Files                434      434              
  Lines              27603    27189     -414     
  Branches            1274     1268       -6     
=================================================
- Hits               16421    16086     -335     
+ Misses             11182    11103      -79
Impacted Files Coverage Δ
...e/js/data-set-import/controllers/file-upload-s3.js 70.37% <ø> (+1.13%) ⬆️
refinery/core/models.py 76.08% <100%> (-1.06%) ⬇️
refinery/data_set_manager/test_views.py 100% <100%> (ø) ⬆️
refinery/data_set_manager/views.py 58.94% <92.85%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3e00d...42a3dfe. Read the comment docs.

@scottx611x scottx611x requested a review from jkmarx July 19, 2018 16:56
@scottx611x scottx611x added this to the Release 1.6.5 milestone Jul 19, 2018
@scottx611x scottx611x added this to Backlog in Scott O. Tasks via automation Jul 19, 2018
@scottx611x scottx611x merged commit 9073048 into release-1.6.5 Jul 19, 2018
Scott O. Tasks automation moved this from Backlog to Done Jul 19, 2018
@scottx611x scottx611x deleted the scottx611x/fix_add_file_source_translation branch October 26, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants