-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest commit hash to site #741
Comments
|
@ngehlenborg Sorry, I did not see this comment before I closed this issue, but I ended up using |
Note that if the subprocess call to launch git produces an exception the whole application will fail to start. |
fix |
Closed with commit: a100b05 |
Reopening, please see my comment on your commit for details. |
Fixed in f48b57f |
Running fe77b29. Commit URL is displayed as git@github.com:parklab/refinery-platform/commit/fe77b29e84accc87221daca0333d9f040c5f5db3. |
Can you describe what you expect? |
The link is broken, it should point to Github, for example: fe77b29. In any case, this is not a priority at the moment. |
@hackdna I'm not going to work on this immediately, but could you tell me what settings configuration you were using for this, as well as anything else that I would need to replicate the issue? |
the "URL" comes from the git remote whence the git repo was cloned. See this code in base.py: https://github.com/parklab/refinery-platform/blob/fe77b29e84accc87221daca0333d9f040c5f5db3/refinery/config/settings/base.py#L475 So if you used a git remote of the form the AWS install uses We can of course translate from |
@drj Thanks for shedding some light on this! |
Closing as now we just include the full SHA without a link. |
This will aid in debugging which code is being used by a specific instance.
Potentially add this info within the
About
tab.The text was updated successfully, but these errors were encountered: