Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset API always returns is_owner=true #826

Closed
flekschas opened this issue Dec 14, 2015 · 3 comments
Closed

Dataset API always returns is_owner=true #826

flekschas opened this issue Dec 14, 2015 · 3 comments
Labels
api bug dataset important
Milestone
Release 1.6.9

Comments

@flekschas
Copy link
Member

Reproduce:

  1. Login as non-admin user A
  2. Upload dataset X
  3. Share dataset X with the public
  4. Login as non-admin user B
  5. API will return dataset X with is_owner=true for user B.

Observed:

  1. API will return dataset X with is_owner=true for user B.

Expected:

  1. API will return dataset X with is_owner=false for user B.
@flekschas flekschas added this to the Next milestone Dec 14, 2015
@flekschas
Copy link
Member Author

I guess this is currently an expected behavior because when sharing a dataset with somebody we are giving that group add permission, which in our case is equivalent to sharing the ownership.

See ownership definitions:
https://github.com/parklab/refinery-platform/blob/develop/refinery/core/models.py#L260

See sharing definition:
https://github.com/parklab/refinery-platform/blob/develop/refinery/core/models.py#L304

Is that a desired behavior?

@flekschas flekschas added question and removed bug labels Dec 14, 2015
@hackdna hackdna modified the milestone: Next Jan 5, 2016
@scottx611x scottx611x mentioned this issue Jan 5, 2016
Open
1 task
flekschas added a commit that referenced this issue Jan 11, 2016
@flekschas
Quick fix for the ownership issue: changed checking for add to share …
7fde220 
…permission in order to determine ownership. Addresses #826.
@hackdna hackdna added this to the Next milestone Aug 19, 2016
@hackdna
Copy link
Member

hackdna commented Aug 19, 2016

I've observed this with "Transcription factor binding during intestinal cell differentiation [TFB]". Commit: e8b9869

@jkmarx jkmarx removed this from the Next milestone Oct 20, 2016
@jkmarx jkmarx added bug and removed question labels Feb 1, 2017
@jkmarx jkmarx added this to the Next milestone Oct 27, 2017
@jkmarx jkmarx removed this from the Next milestone Mar 20, 2018
@jkmarx jkmarx added this to the Release 1.6.9 milestone Mar 20, 2019
@jkmarx
Copy link
Member

jkmarx commented Mar 22, 2019

Resolved previously with https://github.com/refinery-platform/refinery-platform/pull/2959/files

@jkmarx jkmarx closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api bug dataset important
Projects
None yet
Milestone
Release 1.6.9
Development

No branches or pull requests
3 participants
@hackdna @flekschas @jkmarx