Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on AWS the supervisord.conf file is wrong. #923

Closed
drj11 opened this issue Mar 2, 2016 · 8 comments
Closed

on AWS the supervisord.conf file is wrong. #923

drj11 opened this issue Mar 2, 2016 · 8 comments
Assignees
Milestone

Comments

@drj11
Copy link
Contributor

drj11 commented Mar 2, 2016

As @ilya points out in Trello, the supervisord.conf file also needs templating.

@drj11 drj11 self-assigned this Mar 2, 2016
@drj11 drj11 added this to the Palmer milestone Mar 2, 2016
@drj11
Copy link
Contributor Author

drj11 commented Mar 2, 2016

@ngehlenborg ngehlenborg modified the milestones: Palmer, Quincy Mar 8, 2016
@drj11
Copy link
Contributor Author

drj11 commented Mar 9, 2016

Fixed by #937

@hackdna
Copy link
Member

hackdna commented Mar 9, 2016

Still a problem when running commit 11b9d80. In supervisord.conf only [program:worker1] section contains
environment = PATH="/home/ubuntu/.virtualenvs/refinery-platform/bin". All others contain environment = PATH="/bin".

@drj11
Copy link
Contributor Author

drj11 commented Mar 10, 2016

Yes, the previous PR, #937, still wasn't right.

Now that you've merged that one, I've made another PR which should be right this time. #941

@hackdna
Copy link
Member

hackdna commented Mar 10, 2016

It's #941, not #940 [oh yes, I've edited that: drj]. I'll merge it and test it.

@drj11
Copy link
Contributor Author

drj11 commented Mar 11, 2016

@ilya did you know that you don't need to merge a branch to test deployment on AWS by the way? (as long as it's a pushed commit; it uses your current commit (from git rev-parse HEAD) as the deploy target).

@hackdna
Copy link
Member

hackdna commented Mar 11, 2016

Yes, the problem is that you can't easily switch branches if you have uncommitted local changes. What would great is to be able to specify an arbitrary commit as the deploy target.

@drj11
Copy link
Contributor Author

drj11 commented Mar 11, 2016

you can git stash, change branch, deploy, change branch back, git stash pop. but that is long enough to be error prone. In principle what you suggest is doable because all the current thing does is set GIT_BRANCH (see the stack.py script). That could be changed so it was possible to override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants