Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/public group bug fix #1424

Merged
merged 9 commits into from Sep 27, 2016
Merged

Jkmarx/public group bug fix #1424

merged 9 commits into from Sep 27, 2016

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Sep 23, 2016

Resolves #1304 and resolves #1305 and resolves #1017

@jkmarx jkmarx added this to the v1.5.0 milestone Sep 23, 2016
@codecov-io
Copy link

codecov-io commented Sep 23, 2016

Current coverage is 41.89% (diff: 0.00%)

Merging #1424 into develop will decrease coverage by <.01%

@@            develop      #1424   diff @@
==========================================
  Files            91         91          
  Lines         12610      12612     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5284       5284          
- Misses         7326       7328     +2   
  Partials          0          0          

Powered by Codecov. Last update 601615c...1e65407

@jkmarx
Copy link
Member Author

jkmarx commented Sep 23, 2016

Remove a couple of alerts and opted for warning. But ui updates, should prevent user from leaving if last member.
screen shot 2016-09-23 at 2 11 47 pm

Final w/o warning for non-manager member.
screen shot 2016-09-23 at 4 00 15 pm

@jkmarx jkmarx merged commit 9493da3 into develop Sep 27, 2016
@jkmarx jkmarx deleted the jkmarx/public-group-bug-fix branch September 27, 2016 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants