Improve AWS resource tags handling #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought you wanted the tags in |
|
@drj11 Yes, this is just a quick fix mainly to enable easier handling of the tags |
|
looks good, but I haven't tried launching one. I'll do that now. |
drj11
reviewed
Jan 26, 2017
| raise ConfigError() | ||
|
|
||
| if 'owner' not in tags: | ||
| tags['owner'] = os.popen("git config --get user.email").read().rstrip() |
There was a problem hiding this comment.
Thanks but I copied this from your code :)
drj11
reviewed
Jan 26, 2017
|
|
||
| department: dbmi | ||
| environment: dev | ||
| project: |
There was a problem hiding this comment.
an empty project currently means that using this template without changing it fails.
I think it would be nice if was filled in with something so that it can be used without changing it.
But then I was thinking that maybe it's a good thing that you have to change it.
The error is obscure though:
$ make web-stack
python stack.py > web.json
Configuration saved to s3://refinery-gygexukbykxpm/refinery-config-20170126T1457
TZ=UTC date +refinery-web-%Y%m%dT%H%M > aws-config/stack-name
aws cloudformation create-stack --capabilities CAPABILITY_IAM --stack-name $(cat aws-config/stack-name) --template-body file://web.json
A client error (ValidationError) occurred when calling the CreateStack operation: [/Resources/RDSInstance/Type/Tags/0/Value] 'null' values are not allowed in templates
Makefile:7: recipe for target 'web-stack' failed
make: *** [web-stack] Error 255
|
launched one. works. Use your skill and judgement to address my comments (I'm happy if you decide to change nothing), then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.