Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent console errors when in data set 2. #1607

Merged
merged 1 commit into from Feb 10, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Feb 2, 2017

This just adds a conditional to prevent data set 1 solr table generation when in the data set 2 browser. The indent makes it look like a greater change.

@jkmarx jkmarx added this to the Release 1.5.4 milestone Feb 2, 2017
@jkmarx jkmarx self-assigned this Feb 2, 2017
@codecov-io
Copy link

Codecov Report

Merging #1607 into develop will not impact coverage.

@@           Coverage Diff            @@
##           develop    #1607   +/-   ##
========================================
  Coverage    35.23%   35.23%           
========================================
  Files          344      344           
  Lines        23636    23636           
  Branches      1256     1256           
========================================
  Hits          8329     8329           
  Misses       15307    15307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e287c2e...7e9232a. Read the comment docs.

@jkmarx jkmarx merged commit 79cd288 into develop Feb 10, 2017
@jkmarx jkmarx deleted the jkmarx/data-set-2-fix-minor-console-errors branch February 10, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants