Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base path and make public. #1630

Merged
merged 3 commits into from Mar 14, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Mar 13, 2017

Resolves #1628 and resolves #1627

@jkmarx jkmarx added this to the Release 1.5.5 milestone Mar 13, 2017
@jkmarx jkmarx self-assigned this Mar 13, 2017
Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like MetadataTableImportCtrl needs updating as well.

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #1630 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1630      +/-   ##
===========================================
+ Coverage    36.03%   36.04%   +<.01%     
===========================================
  Files          343      343              
  Lines        23596    23592       -4     
  Branches      1258     1256       -2     
===========================================
  Hits          8503     8503              
+ Misses       15093    15089       -4
Impacted Files Coverage Δ
...e/js/data-set-import/controllers/metadata-table.js 21.55% <ø> (+0.5%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2480b...62405f4. Read the comment docs.

@jkmarx jkmarx requested a review from scottx611x March 14, 2017 12:24
@scottx611x scottx611x merged commit f66f458 into develop Mar 14, 2017
@jkmarx jkmarx deleted the jkmarx/data-set-upload-enhancement2 branch March 20, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Make Public" field from data set upload page remove base path field from file upload page
4 participants