Scottx611x/docker puppet install #1664
Conversation
… shouldn't commit from Vagrant anyways.
Codecov Report
@@ Coverage Diff @@
## develop #1664 +/- ##
========================================
Coverage 37.69% 37.69%
========================================
Files 369 369
Lines 24341 24341
Branches 1260 1260
========================================
Hits 9175 9175
Misses 15166 15166Continue to review full report at Codecov.
|
deployment/Puppetfile
Outdated
| @@ -1,5 +1,6 @@ | |||
| forge "https://forgeapi.puppetlabs.com" | |||
|
|
|||
| mod 'garethr-docker', '5.3.0' | |||
There was a problem hiding this comment.
Why not use the puppetlabs/docker_platform?
There was a problem hiding this comment.
Not sure, it looks exactly the same as: garethr-docker
Actually it depends on it: https://forge.puppet.com/puppetlabs/docker_platform/dependencies
There was a problem hiding this comment.
The benefit of the puppetlabs modules is that they are provided by the Puppet team. Also, garethr-docker was last updated about a year ago and it supports only up to Ubuntu 14.04. The puppetlabs version was last updated a week ago and supports Ubuntu 16.04. Basically, it looks like it is probably going to replace garethr-docker.
| @@ -0,0 +1,5 @@ | |||
| class refinery::docker_ { | |||
There was a problem hiding this comment.
Because there is already a classdocker and Puppet complains about a naming conflict
| @@ -229,6 +226,7 @@ | |||
| Class["ui"], | |||
| Class["solr"], | |||
| Class["neo4j"], | |||
| Class["docker"], | |||
There was a problem hiding this comment.
Why does supervisor require docker?
There was a problem hiding this comment.
I don't think supervisor explicitly needs docker, but i don't think we want to start up everything without it since our app will depend on docker working.
There was a problem hiding this comment.
I'd remove that since there is no explicit dependency and docker installation will still happen by the time the Refinery manifest is applied.
| @@ -1,6 +1,6 @@ | |||
| class refinery::selenium { | |||
| $geckodriver_version = 'v0.15.0' | |||
| $filename = "geckodriver-${geckodriver_version}-linux32.tar.gz" | |||
| $filename = "geckodriver-${geckodriver_version}-linux64.tar.gz" | |||
There was a problem hiding this comment.
Because Geckodriver is not providing 32 bit builds in its newer releases anymore
| @@ -0,0 +1,5 @@ | |||
| class refinery::docker_ { | |||
| class { 'docker': | |||
There was a problem hiding this comment.
This should be class { '::docker': to indicate global namespace explicitly
There was a problem hiding this comment.
Okay, should this be changed throughout our manifests? I was just following the syntax that we had used throughout
There was a problem hiding this comment.
Also this answer is from 2012, is it still relevant?
There was a problem hiding this comment.
Yes, it's the reason you got the naming error when trying to use refinery::docker on the line above. Here's the source in Puppet docs (still relevant as of Puppet v3.5 and we are using v3.4.3): https://docs.puppet.com/puppet/3.5/lang_namespaces.html#workaround
There was a problem hiding this comment.
And yes, this should be changed in the rest of the manifests but in a separate branch.
| @@ -0,0 +1,5 @@ | |||
| class refinery::docker { | |||
| class { '::docker': | |||
| docker_users => [$app_user] | |||
No description provided.