Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/clean up ui grid defaults #1687

Merged
merged 104 commits into from Apr 25, 2017
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Apr 24, 2017

  • Remove ui-grid default selection and methods associated

@jkmarx jkmarx self-assigned this Apr 24, 2017
@jkmarx jkmarx added this to the Release 1.5.6 milestone Apr 24, 2017
@codecov-io
Copy link

codecov-io commented Apr 24, 2017

Codecov Report

Merging #1687 into develop will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1687      +/-   ##
===========================================
- Coverage    38.59%   38.57%   -0.03%     
===========================================
  Files          364      364              
  Lines        24878    24806      -72     
  Branches      1265     1248      -17     
===========================================
- Hits          9602     9568      -34     
+ Misses       15276    15238      -38
Impacted Files Coverage Δ
...ui/source/js/commons/services/tools-definitions.js 100% <ø> (ø) ⬆️
...ui/source/js/file-browser/ctrls/node-group-ctrl.js 75% <ø> (+1.08%) ⬆️
...js/file-browser/services/selected-nodes-service.js 82.6% <ø> (-3.29%) ⬇️
refinery/ui/source/js/workflows/ctrl.js 75% <ø> (+1.92%) ⬆️
refinery/tool_manager/tests.py 98.12% <100%> (ø) ⬆️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 35.94% <33.33%> (+3.51%) ⬆️
...nery/ui/source/js/file-browser/services/factory.js 78.06% <50%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d206c7e...9d87cd8. Read the comment docs.

@jkmarx jkmarx merged commit c0073de into develop Apr 25, 2017
@jkmarx jkmarx deleted the jkmarx/clean-up-ui-grid-defaults branch April 25, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants