Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/data set2 indicator column #1688

Merged
merged 113 commits into from Apr 27, 2017
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Apr 26, 2017

  • Add indicator column
    Add template
    Display color
    Darken arrow if popover selected or row is selected
    Remove/remove all clears styling
    Adjust css to show ... for overflow
    Ensure display during cont scrolling and filtering (any resets)

add gif v2

remove

@codecov-io
Copy link

codecov-io commented Apr 26, 2017

Codecov Report

Merging #1688 into develop will increase coverage by 0.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1688      +/-   ##
===========================================
+ Coverage    38.57%   38.58%   +0.01%     
===========================================
  Files          364      364              
  Lines        24806    24833      +27     
  Branches      1248     1249       +1     
===========================================
+ Hits          9568     9583      +15     
- Misses       15238    15250      +12
Impacted Files Coverage Δ
.../tool-launch/services/file-relationship-service.js 38.82% <0%> (ø) ⬆️
.../file-browser/directives/node-selection-popover.js 91.66% <100%> (+0.75%) ⬆️
.../file-browser/ctrls/node-selection-popover-ctrl.js 100% <100%> (ø) ⬆️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 35.93% <35.71%> (-0.02%) ⬇️
...nery/ui/source/js/file-browser/services/factory.js 77.01% <60%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0073de...a12d42b. Read the comment docs.

@jkmarx jkmarx self-assigned this Apr 26, 2017
@jkmarx jkmarx added this to the Release 1.5.6 milestone Apr 26, 2017
@jkmarx jkmarx merged commit 475c62d into develop Apr 27, 2017
@jkmarx jkmarx deleted the jkmarx/data-set2-indicator-column branch April 27, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants