Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event to close popover when clicking on select icon. #1741

Merged
merged 53 commits into from May 23, 2017
Merged

Add event to close popover when clicking on select icon. #1741

merged 53 commits into from May 23, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented May 22, 2017

  • Allows user to close popover by clicking on selection.
    select-close

jkmarx added 30 commits May 4, 2017 10:27
@jkmarx
Add tools service and unit test.
34ec576
@jkmarx
Fix bug due to duplicate module names.
e475c3f
@jkmarx
Fix service name to reflect api.
a34a102
@jkmarx
Rename module for clarity.
82c257a
@jkmarx
Seperate and rename module for clarity.
cd90091
@jkmarx
Fix group index bug.
ab74fa9
@jkmarx
Fix indexing.
bd74d68
@jkmarx
Add generate list config.
c1699f8
@jkmarx
Resolve merge conflict.
4f28897
@jkmarx
Launch visualization tool.
8bd072d
@jkmarx
Add template generator helper function.
610f8d9
@jkmarx
Launch config tested for simple tools.
02f8115
@jkmarx
Update unit test.
a7fe07e
@jkmarx
Remove empty sets helper method.
56f553a
@jkmarx
Add generate template unit test.
7d71ae5
@jkmarx
Refactor and add additional unit test.
d5c08a6
@jkmarx
Add postToolLaunch unit test.
dc2fdf8
@jkmarx
Update API to accept a str instead a str of str uuids.
53429f0
@jkmarx
Add unit tests for generating file str.
7ac7488
@jkmarx
Add insert comma method and update unit test.
ae0dafe
@jkmarx
Remove unused attribute.
996038d
@jkmarx
Update indices name for clarity.
ea77f41
@jkmarx
Remove unneccessary code.
288fa6d
@jkmarx
Add comments.
27d2ee8
@jkmarx
Fix edge case by generating correct size template.
a8c3aa2
@jkmarx
Add comments.
97b3372
@jkmarx
Update index name for clarity.
cdcd542
@jkmarx
Update description.
4c25bc4
@jkmarx
Refactor.
77e0db7
@jkmarx
Add comments.
38e611f
@jkmarx jkmarx added this to the Release 1.5.7 milestone May 22, 2017
@jkmarx jkmarx self-assigned this May 22, 2017
@jkmarx jkmarx requested review from hackdna and scottx611x May 22, 2017 20:37
@codecov-io
Copy link

codecov-io commented May 22, 2017 •
edited

Codecov Report

Merging #1741 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1741      +/-   ##
===========================================
- Coverage    39.84%   39.83%   -0.01%     
===========================================
  Files          369      369              
  Lines        25257    25259       +2     
  Branches      1272     1273       +1     
===========================================
  Hits         10063    10063              
- Misses       15194    15196       +2
Impacted Files Coverage Δ
refinery/ui/source/js/file-browser/ctrls/ctrl.js 35.77% <0%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579fbf7...241477b. Read the comment docs.

@jkmarx jkmarx changed the base branch from jkmarx/data-set-2-input-group-display to develop May 23, 2017 12:06
@jkmarx jkmarx merged commit bb09f29 into develop May 23, 2017
@jkmarx jkmarx deleted the jkmarx/update-node-selection-popover-event branch May 23, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackdna hackdna hackdna approved these changes

@scottx611x scottx611x scottx611x approved these changes

Assignees

@jkmarx jkmarx

Labels
None yet
Projects
None yet
Milestone
Release 1.5.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkmarx @codecov-io @hackdna @scottx611x