Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/remove node group #1744

Merged
merged 18 commits into from May 26, 2017
Merged

Jkmarx/remove node group #1744

merged 18 commits into from May 26, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented May 24, 2017

Resolves #1643

  • Removes node group services, references, helper methods from UI
  • Removes node group API, model, and serializer

@codecov-io
Copy link

codecov-io commented May 24, 2017

Codecov Report

Merging #1744 into develop will decrease coverage by 0.49%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #1744     +/-   ##
==========================================
- Coverage    39.84%   39.35%   -0.5%     
==========================================
  Files          369      363      -6     
  Lines        25284    24863    -421     
  Branches      1277     1264     -13     
==========================================
- Hits         10075     9784    -291     
+ Misses       15209    15079    -130
Impacted Files Coverage Δ
refinery/ui/source/js/workflows/ctrl.js 73.68% <ø> (-1.32%) ⬇️
refinery/core/models.py 58.13% <ø> (-0.39%) ⬇️
...nery/ui/source/js/file-browser/services/factory.js 75.49% <ø> (-1.53%) ⬇️
refinery/core/utils.py 32.45% <ø> (-2.55%) ⬇️
...urce/js/analysis-launch/services/config-service.js 16.66% <ø> (ø) ⬆️
...efinery/ui/source/js/analysis-launch/modal-ctrl.js 7.14% <0%> (+1.26%) ⬆️
refinery/core/tests.py 99.68% <100%> (-0.03%) ⬇️
.../file-browser/directives/node-selection-popover.js 91.66% <100%> (ø) ⬆️
...ui/source/js/tool-launch/ctrls/input-group-ctrl.js 84.31% <100%> (ø) ⬆️
refinery/core/urls.py 100% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0a40b...284b9be. Read the comment docs.

@jkmarx jkmarx requested review from hackdna and scottx611x May 24, 2017 20:27
@jkmarx jkmarx self-assigned this May 24, 2017
Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the removal of NodeGroup break our current way of launching Analyses?

@jkmarx
Copy link
Member Author

jkmarx commented May 25, 2017

@scottx611x Node Groups was only used in the data set two browser. It was used initially for launching analyses in the data set 2.

@jkmarx jkmarx merged commit f7eb940 into develop May 26, 2017
@jkmarx jkmarx deleted the jkmarx/remove-node-group branch May 26, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants