Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update smaller services according to style guide. #1788

Merged
merged 2 commits into from Jun 13, 2017
Merged

Update smaller services according to style guide. #1788

merged 2 commits into from Jun 13, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jun 9, 2017

LAST ONE
Refactor smaller services according to style guide

  • Move declaration up
  • Reorder dependencies
  • Reorder methods

@jkmarx jkmarx added this to the Release 1.5.7 milestone Jun 9, 2017
@jkmarx jkmarx self-assigned this Jun 9, 2017
@jkmarx jkmarx requested review from hackdna and scottx611x June 9, 2017 19:36
@codecov-io
Copy link

codecov-io commented Jun 9, 2017 •
edited

Codecov Report

Merging #1788 into jkmarx/file-browser-refactor-services will increase coverage by 0.15%.
The diff coverage is 76.85%.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           jkmarx/file-browser-refactor-services    #1788      +/-   ##
=========================================================================
+ Coverage                                  40.14%   40.29%   +0.15%     
=========================================================================
  Files                                        383      386       +3     
  Lines                                      25246    25303      +57     
  Branches                                    1268     1271       +3     
=========================================================================
+ Hits                                       10135    10196      +61     
+ Misses                                     15111    15107       -4
Impacted Files Coverage Δ
...ource/js/file-browser/services/is-owner-service.js 100% <100%> (ø) ⬆️
...rce/js/file-browser/services/reset-grid-service.js 100% <100%> (ø) ⬆️
.../js/file-browser/services/files-loading-service.js 100% <100%> (ø) ⬆️
...nery/ui/source/js/file-browser/services/factory.js 72.14% <100%> (-2.86%) ⬇️
...rce/js/file-browser/services/file-param-service.js 100% <100%> (ø)
.../js/file-browser/services/assay-filters-service.js 100% <100%> (ø)
...source/js/file-browser/directives/assay-filters.js 58.33% <38.46%> (-0.5%) ⬇️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 34.65% <40%> (-1.68%) ⬇️
...source/js/file-browser/ctrls/assay-filters-ctrl.js 66.66% <66.66%> (ø)
...s/file-browser/services/selected-filter-service.js 84.61% <84.31%> (+2.79%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a5e75...8596da9. Read the comment docs.

@jkmarx
Jkmarx/generalize attribute filter (#1790)
8596da9 
* Move uiSelectedFields to service.

* Add assay filter service.

* Move methods to assay-filters-ctrl

* Update initialize events.

* Add and update unit test for ctrl.

* Fix bug related to url query.

* Remove broadcast and use watcher.

* Remove console.

* Update unit test.

* Add ctrl comments.

* Fix scope and remove unneccessary variable.

* fix bug due to url query generation.

* Add comments and unit test.

* Add unit test and comments.
@jkmarx jkmarx merged commit ad9f91d into jkmarx/file-browser-refactor-services Jun 13, 2017
@jkmarx jkmarx deleted the jkmarx/file-browser-refactor-smaller-services branch June 13, 2017 17:28
jkmarx added a commit that referenced this pull request Jun 13, 2017
@jkmarx
Jkmarx/file browser refactor services (#1787)
acaf0c3 
* Refactor main factory file according to style guide.

* Update main factory test and remove unneccessary variables.

* Update smaller services according to style guide. (#1788)

* Update smaller services according to style guide.

* Jkmarx/generalize attribute filter (#1790)

* Move uiSelectedFields to service.

* Add assay filter service.

* Move methods to assay-filters-ctrl

* Update initialize events.

* Add and update unit test for ctrl.

* Fix bug related to url query.

* Remove broadcast and use watcher.

* Remove console.

* Update unit test.

* Add ctrl comments.

* Fix scope and remove unneccessary variable.

* fix bug due to url query generation.

* Add comments and unit test.

* Add unit test and comments.
jkmarx added a commit that referenced this pull request Jun 13, 2017
@jkmarx
Update module and setting file to style guide. (#1786)
c81f3d6 
* Update module and setting file to style guide.

* Jkmarx/file browser refactor services (#1787)

* Refactor main factory file according to style guide.

* Update main factory test and remove unneccessary variables.

* Update smaller services according to style guide. (#1788)

* Update smaller services according to style guide.

* Jkmarx/generalize attribute filter (#1790)

* Move uiSelectedFields to service.

* Add assay filter service.

* Move methods to assay-filters-ctrl

* Update initialize events.

* Add and update unit test for ctrl.

* Fix bug related to url query.

* Remove broadcast and use watcher.

* Remove console.

* Update unit test.

* Add ctrl comments.

* Fix scope and remove unneccessary variable.

* fix bug due to url query generation.

* Add comments and unit test.

* Add unit test and comments.
jkmarx added a commit that referenced this pull request Jun 13, 2017
@jkmarx
Jkmarx/file browser refactor ctrl (#1785)
8c367c8 
* Refactor directives according to angular style guide.

* Remove unneccessary variable.

* Fix spacing.

* Remove unneccessary rootScope variable.

* Refactor ctrl.

* Reorder inputs.

* Update module and setting file to style guide. (#1786)

* Update module and setting file to style guide.

* Jkmarx/file browser refactor services (#1787)

* Refactor main factory file according to style guide.

* Update main factory test and remove unneccessary variables.

* Update smaller services according to style guide. (#1788)

* Update smaller services according to style guide.

* Jkmarx/generalize attribute filter (#1790)

* Move uiSelectedFields to service.

* Add assay filter service.

* Move methods to assay-filters-ctrl

* Update initialize events.

* Add and update unit test for ctrl.

* Fix bug related to url query.

* Remove broadcast and use watcher.

* Remove console.

* Update unit test.

* Add ctrl comments.

* Fix scope and remove unneccessary variable.

* fix bug due to url query generation.

* Add comments and unit test.

* Add unit test and comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackdna hackdna hackdna approved these changes

@scottx611x scottx611x scottx611x approved these changes

Assignees

@jkmarx jkmarx

Labels
None yet
Projects
None yet
Milestone
Release 1.5.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkmarx @codecov-io @hackdna @scottx611x