Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/row template updates #1816

Merged
merged 3 commits into from Jun 20, 2017
Merged

Jkmarx/row template updates #1816

merged 3 commits into from Jun 20, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jun 20, 2017

  • reposition popover to bottom
  • in node selection popover: show template and name if file is selected
  • add highlights for active node
  • pin selection and input node group column
  • keep icons solid

@jkmarx jkmarx requested a review from scottx611x June 20, 2017 20:17
@jkmarx jkmarx self-assigned this Jun 20, 2017
@jkmarx jkmarx added this to the Release 1.5.7 milestone Jun 20, 2017
@codecov-io
Copy link

Codecov Report

Merging #1816 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1816   +/-   ##
=======================================
  Coverage     40.6%   40.6%           
=======================================
  Files          392     392           
  Lines        25479   25479           
  Branches      1274    1274           
=======================================
  Hits         10347   10347           
  Misses       15132   15132
Impacted Files Coverage Δ
.../file-browser/directives/node-selection-popover.js 91.3% <ø> (ø) ⬆️
...nery/ui/source/js/file-browser/services/factory.js 72.14% <ø> (ø) ⬆️
refinery/ui/source/js/file-browser/module.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f40767...3ff1957. Read the comment docs.

@jkmarx jkmarx merged commit 359e7d5 into develop Jun 20, 2017
@jkmarx jkmarx deleted the jkmarx/row-template-updates branch June 20, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants