Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/missing nav bar bug #1834

Merged
merged 26 commits into from Jun 26, 2017
Merged

Jkmarx/missing nav bar bug #1834

merged 26 commits into from Jun 26, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jun 26, 2017

  • Minor bug
  • Adjust css

@codecov-io
Copy link

codecov-io commented Jun 26, 2017

Codecov Report

Merging #1834 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1834      +/-   ##
===========================================
+ Coverage    41.25%   41.26%   +<.01%     
===========================================
  Files          394      394              
  Lines        25873    25874       +1     
  Branches      1281     1281              
===========================================
+ Hits         10675    10676       +1     
  Misses       15198    15198
Impacted Files Coverage Δ
.../file-browser/directives/node-selection-popover.js 91.3% <ø> (ø) ⬆️
.../file-browser/ctrls/node-selection-popover-ctrl.js 100% <100%> (ø) ⬆️
...ui/source/js/tool-launch/ctrls/tool-params-ctrl.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b927bc4...82b1cde. Read the comment docs.

@jkmarx jkmarx requested a review from scottx611x June 26, 2017 17:03
Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small css syntax stuff, Not blocking for a merge, but might be good to look into

@@ -267,8 +267,10 @@
}
}

#node-selection-popover {
width: 400px;
#assay-files-table {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just do:

#assay-files-table.popover {
 width: 400px !important;
}

But thats just syntax preference, not sure what we prefer

@@ -347,3 +349,9 @@ ul.plain {
list-style: none;
padding-left: 0;
}

.refinery-subheader {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same syntax here

@jkmarx jkmarx merged commit 5f3151d into develop Jun 26, 2017
@jkmarx jkmarx deleted the jkmarx/missing-nav-bar-bug branch June 26, 2017 21:03
@jkmarx jkmarx self-assigned this Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants