Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/details owner name bug #1839

Merged
merged 34 commits into from Jun 27, 2017
Merged

Jkmarx/details owner name bug #1839

merged 34 commits into from Jun 27, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jun 26, 2017

  • Fix bug when API does not provide user information

jkmarx and others added 30 commits June 20, 2017 10:02
@codecov-io
Copy link

codecov-io commented Jun 26, 2017

Codecov Report

Merging #1839 into develop will increase coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1839      +/-   ##
===========================================
+ Coverage    41.26%   41.26%   +<.01%     
===========================================
  Files          394      394              
  Lines        25874    25876       +2     
  Branches      1281     1283       +2     
===========================================
+ Hits         10676    10677       +1     
- Misses       15198    15199       +1
Impacted Files Coverage Δ
.../ui/source/js/data-set-about/ctrls/sharing-ctrl.js 54.54% <0%> (-2.6%) ⬇️
refinery/ui/source/js/commons/services/users.js 93.33% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03328b...01315fb. Read the comment docs.

@jkmarx jkmarx requested a review from scottx611x June 27, 2017 12:21
@jkmarx jkmarx self-assigned this Jun 27, 2017
@jkmarx jkmarx added this to the Release 1.5.7 milestone Jun 27, 2017
@jkmarx jkmarx merged commit 085e076 into develop Jun 27, 2017
@jkmarx jkmarx deleted the jkmarx/details-owner-name-bug branch June 27, 2017 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants