Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/fix icon bug #1843

Merged
merged 1 commit into from Jun 27, 2017
Merged

Jkmarx/fix icon bug #1843

merged 1 commit into from Jun 27, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jun 27, 2017

No description provided.

@jkmarx jkmarx changed the base branch from develop to jkmarx/remove-group-bug June 27, 2017 13:26
@jkmarx jkmarx requested a review from scottx611x June 27, 2017 13:26
@jkmarx jkmarx self-assigned this Jun 27, 2017
@jkmarx jkmarx added this to the Release 1.5.7 milestone Jun 27, 2017
@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #1843 into jkmarx/remove-group-bug will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           jkmarx/remove-group-bug    #1843   +/-   ##
========================================================
  Coverage                    41.27%   41.27%           
========================================================
  Files                          394      394           
  Lines                        25892    25892           
  Branches                      1284     1284           
========================================================
  Hits                         10687    10687           
  Misses                       15205    15205

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e02c09...78d3ba8. Read the comment docs.

@jkmarx jkmarx merged commit 6050c18 into jkmarx/remove-group-bug Jun 27, 2017
@jkmarx jkmarx deleted the jkmarx/fix-icon-bug branch June 27, 2017 14:11
@jkmarx jkmarx restored the jkmarx/fix-icon-bug branch June 27, 2017 14:11
jkmarx added a commit that referenced this pull request Jun 27, 2017
jkmarx added a commit that referenced this pull request Jun 27, 2017
* Fix remove bug by readding helper methods to remove input group w/ length 1.

* Remove consoles.

* Fix index which resolves nav icon bug. (#1843)
@jkmarx jkmarx deleted the jkmarx/fix-icon-bug branch June 27, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants