Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELB Logging in CloudFormation #1860

Merged
merged 10 commits into from Jul 6, 2017
Merged

ELB Logging in CloudFormation #1860

merged 10 commits into from Jul 6, 2017

Conversation

drj11
Copy link
Contributor

@drj11 drj11 commented Jun 30, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 30, 2017

Codecov Report

Merging #1860 into develop will increase coverage by 2.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1860      +/-   ##
===========================================
+ Coverage    41.39%   43.54%   +2.15%     
===========================================
  Files          394      400       +6     
  Lines        25861    27338    +1477     
  Branches      1279     1318      +39     
===========================================
+ Hits         10704    11904    +1200     
- Misses       15157    15434     +277
Impacted Files Coverage Δ
.../source/js/user-file-browser/services/user-file.js 78.57% <0%> (-21.43%) ⬇️
refinery/data_set_manager/search_indexes.py 49.01% <0%> (-18.09%) ⬇️
refinery/user_files_manager/views.py 66.66% <0%> (-16.67%) ⬇️
...ui/source/js/tool-launch/ctrls/tool-select-ctrl.js 64.15% <0%> (-12.78%) ⬇️
...ce/js/tool-launch/ctrls/tool-launch-button-ctrl.js 52.38% <0%> (-11.91%) ⬇️
...ui/source/js/user-file-browser/services/factory.js 25.97% <0%> (-11.87%) ⬇️
...ource/js/data-set-import/directives/file-upload.js 92.3% <0%> (-7.7%) ⬇️
...le-browser/ctrls/user-file-browser-filters-ctrl.js 13.88% <0%> (-5.16%) ⬇️
refinery/ui/source/js/commons/services/users.js 89.47% <0%> (-3.86%) ⬇️
.../tool-launch/ctrls/input-control-inner-nav-ctrl.js 96.07% <0%> (-0.36%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62e159...ecea1f5. Read the comment docs.

@hackdna hackdna merged commit 1927f9f into develop Jul 6, 2017
@drj11 drj11 deleted the drj11/elb-logging branch July 7, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants