Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scottx611x/is tool based cleanup #2222

Merged
merged 19 commits into from
Oct 17, 2017
Merged

Scottx611x/is tool based cleanup #2222

merged 19 commits into from
Oct 17, 2017

Commits on Oct 10, 2017

  1. Remove conditionals and related code that isn't necessary now that we… 

    … can remove `is_tool_based`
    @scottx611x
    scottx611x committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    42c722c View commit details
    Browse the repository at this point in the history

  2. Update Analysis config key names to be uniform, and update schema

    @scottx611x
    scottx611x committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    7abd945 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary tests

    @scottx611x
    scottx611x committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    5600afb View commit details
    Browse the repository at this point in the history

  4. Now that our schema is more basic we don't need the file resolver in … 

    …the validation function
    @scottx611x
    scottx611x committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    019be46 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2017

  1. Remove comment

    @scottx611x
    scottx611x committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    b6c3b24 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2017

  1. No need for intermediate value

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    498dafc View commit details
    Browse the repository at this point in the history

  2. Exception handling

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    3bb48f9 View commit details
    Browse the repository at this point in the history

  3. Fit on one line

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    302dc2c View commit details
    Browse the repository at this point in the history

  4. No need for extra parens

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    e42bb0e View commit details
    Browse the repository at this point in the history

  5. Add note about atomic transactions

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    c143e28 View commit details
    Browse the repository at this point in the history

  6. Remove anti-pattern

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    c4fa720 View commit details
    Browse the repository at this point in the history

  7. Fix bracket styling

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    c1c8060 View commit details
    Browse the repository at this point in the history

  8. Move JSONSchema paths into base.py

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    a26147e View commit details
    Browse the repository at this point in the history

  9. Remove returns in analysis_manager/tasks.py

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    a0a205d View commit details
    Browse the repository at this point in the history

  10. Utilize a single JSON_SCHEMA_FILE_RESOLVER setting for all defined sc… 

    …hemas
    @scottx611x
    scottx611x committed Oct 16, 2017
    1 Configuration menu
    Copy the full SHA
    2f1419f View commit details
    Browse the repository at this point in the history

  11. Merge origin/develop into is_tool_based_cleanup

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    4c5949a View commit details
    Browse the repository at this point in the history

  12. Revert moving JSONSchema paths into base.py

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    abd16e9 View commit details
    Browse the repository at this point in the history

  13. Revert 2f1419f

    @scottx611x
    scottx611x committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    f310f72 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Favor import jsonschema

    @scottx611x
    scottx611x committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    a63fcec View commit details
    Browse the repository at this point in the history