Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackdna/filestoreitem fix #2386

Merged
merged 4 commits into from Nov 21, 2017
Merged

Hackdna/filestoreitem fix #2386

merged 4 commits into from Nov 21, 2017

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Nov 20, 2017

Solve #2380, improve error handling during data set import and cleanup FileStoreItem management using Django admin site.
Contains a DB migration for the file_store app.

@hackdna hackdna added this to the Release 1.6.2 milestone Nov 20, 2017
@codecov-io
Copy link

Codecov Report

Merging #2386 into develop will decrease coverage by 0.01%.
The diff coverage is 38.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2386      +/-   ##
==========================================
- Coverage    50.62%   50.6%   -0.02%     
==========================================
  Files          383     383              
  Lines        26525   26532       +7     
  Branches      1241    1241              
==========================================
- Hits         13427   13426       -1     
- Misses       13098   13106       +8
Impacted Files Coverage Δ
refinery/data_set_manager/views.py 43.29% <0%> (-0.1%) ⬇️
refinery/file_store/tasks.py 43.38% <33.33%> (-0.77%) ⬇️
refinery/file_store/models.py 61.11% <37.5%> (-0.87%) ⬇️
refinery/file_store/admin.py 82.35% <75%> (-5.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47880d5...67e9cf6. Read the comment docs.

@hackdna hackdna merged commit e62910e into develop Nov 21, 2017
@hackdna hackdna deleted the hackdna/filestoreitem-fix branch November 21, 2017 16:22
@hackdna hackdna added this to In Progress in AWS S3 as a storage backend Nov 21, 2017
@hackdna hackdna self-assigned this Nov 27, 2017
@hackdna hackdna moved this from In Progress to QA in AWS S3 as a storage backend Nov 27, 2017
@hackdna hackdna moved this from QA to Done in AWS S3 as a storage backend Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants