Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/download url index bug #2462

Merged
merged 21 commits into from Jan 16, 2018
Merged

Jkmarx/download url index bug #2462

merged 21 commits into from Jan 16, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jan 12, 2018

Resolves #2434
Fixes #2382
Fixes #2290

@jkmarx
Copy link
Member Author

jkmarx commented Jan 12, 2018

@scottx611x I had to change the logic in the search_indexes due to the None status being returned from the .get_datafile_url

@codecov
Copy link

codecov bot commented Jan 12, 2018

Codecov Report

Merging #2462 into develop will decrease coverage by 0.71%.
The diff coverage is 92.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2462      +/-   ##
==========================================
- Coverage    52.11%   51.4%   -0.72%     
==========================================
  Files          389     389              
  Lines        27441   27022     -419     
  Branches      1252    1246       -6     
==========================================
- Hits         14301   13890     -411     
+ Misses       13140   13132       -8
Impacted Files Coverage Δ
...nery/ui/source/js/file-browser/services/factory.js 65.57% <ø> (-0.59%) ⬇️
refinery/file_store/tasks.py 39.68% <0%> (ø) ⬆️
...ui/source/js/user-file-browser/services/factory.js 89.7% <0%> (+0.23%) ⬆️
refinery/data_set_manager/tests.py 99.73% <100%> (-0.09%) ⬇️
refinery/data_set_manager/search_indexes.py 95.78% <100%> (+1.34%) ⬆️
refinery/tool_manager/models.py 96.42% <0%> (-0.01%) ⬇️
refinery/tool_manager/views.py 96.87% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e314bca...ca10032. Read the comment docs.

@jkmarx jkmarx added this to the Release 1.6.2 milestone Jan 16, 2018
@jkmarx jkmarx merged commit 48df946 into develop Jan 16, 2018
@jkmarx jkmarx deleted the jkmarx/download_url_index_bug branch January 16, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants