Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scottx611x/refactor attach outputs dataset #2591

Merged
merged 11 commits into from
Feb 15, 2018
Merged

Scottx611x/refactor attach outputs dataset #2591

merged 11 commits into from
Feb 15, 2018

Commits on Feb 14, 2018

  1. Factor attach_outputs_dataset into digestible pieces, Rename to `at… 

    …tach_derived_nodes_to_dataset`
    @scottx611x
    scottx611x committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    fbe3974 View commit details
    Browse the repository at this point in the history

  2. Rename usage

    @scottx611x
    scottx611x committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    2a2be1a View commit details
    Browse the repository at this point in the history

  3. Renaming in tests

    @scottx611x
    scottx611x committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    dc53581 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. This didn't need to be a property

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    33b7091 View commit details
    Browse the repository at this point in the history

  2. Rename to get_expanded_workflow_graph

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    5159f67 View commit details
    Browse the repository at this point in the history

  3. format() was clearer here

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f4bd7c8 View commit details
    Browse the repository at this point in the history

  4. Use backslash instead of ()

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    9f43aaf View commit details
    Browse the repository at this point in the history

  5. No need for intermediary assignment

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    b1fe518 View commit details
    Browse the repository at this point in the history

  6. Remove redundant if, we just wouldn't loop if not > 0

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    c302cfb View commit details
    Browse the repository at this point in the history

  7. Update repr to include filetype information

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    90e55fd View commit details
    Browse the repository at this point in the history

  8. Update logger now that output_connection uields its filetype info

    @scottx611x
    scottx611x committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    91ecd5b View commit details
    Browse the repository at this point in the history