Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flaky tests. #2613

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Remove flaky tests. #2613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07390b7
Remove flaky tests.
jkmarx Feb 22, 2018
1a798e9
Remove unneccessary selenium tests.
jkmarx Feb 26, 2018
4e166c6
Fix userFilesTest with clear_cache solution.
jkmarx Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
204 changes: 0 additions & 204 deletions refinery/selenium_testing/tests.py
View file
Open in desktop

This file was deleted.

166 changes: 0 additions & 166 deletions refinery/selenium_testing/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,104 +31,6 @@ def tearDown(self):
self.display.stop()


def login(selenium, live_server_url):
"""
Helper method to login to the StaticLiveServerTestCase Refinery instance
:param selenium: selenium webdriver Instance
:param live_server_url: Url of the current StaticLiveServerTestCase
instance
"""
selenium.get(live_server_url)
wait_until_id_clickable(selenium, "refinery-login", MAX_WAIT)
selenium.find_element_by_link_text('Login').click()
wait_until_id_clickable(selenium, "id_username", MAX_WAIT)
selenium.find_element_by_id('id_username').send_keys('guest')
selenium.find_element_by_id('id_password').send_keys('guest')
selenium.find_element_by_xpath('//input[@type="submit"]').click()
wait_until_id_clickable(selenium, "refinery-logout", MAX_WAIT)
assert_body_text(selenium, 'Guest', 'Logout')
selenium.refresh()


def assert_body_text(selenium, search_array=None, *search_texts):
"""
Ensure that some text exists within <body>
:param selenium: selenium webdriver Instance
:param search_array: option array of strings to ensure exist within the
<body>
:param search_texts: extra words to search for, provided as *args
"""
if search_array:
search_texts = search_array
for search_text in search_texts:
try:
WebDriverWait(selenium, 10).until(
ec.text_to_be_present_in_element(
(By.TAG_NAME, 'body'), search_text)
)
except TimeoutException:
raise AssertionError(
'"%s" not in body: \n%s' % (
search_text,
selenium.find_element_by_tag_name('body').text
))


def assert_text_within_id(selenium, search_id, wait_duration, *search_texts):
"""
Ensure that some text exists within a DOM id
:param selenium: selenium webdriver Instance
:param search_id: DOM element id to search for
:param wait_duration: time limit to be used in WebDriverWait()
:param search_texts: extra words to search for, provided as *args
"""
for search_text in search_texts:
try:
WebDriverWait(selenium, wait_duration).until(
ec.text_to_be_present_in_element(
(By.ID, search_id), search_text)
)
except TimeoutException:
raise AssertionError(
'"%s" not in %s: \n%s' % (
search_text,
search_id,
selenium.find_element_by_id(search_id).text
))


def wait_until_id_clickable(selenium, search_id, wait_duration):
"""
Wait for a DOM element to be clickable
:param selenium: selenium webdriver Instance
:param search_id: DOM element id to search for
:param wait_duration: time limit to be used in WebDriverWait()
"""
try:
return WebDriverWait(selenium, wait_duration).until(
ec.element_to_be_clickable((By.ID, search_id)))
except TimeoutException:
raise AssertionError(
"Element with id: {} was not clickable within the {} second "
"wait period.".format(search_id, wait_duration))


def wait_until_id_visible(selenium, search_id, wait_duration):
"""
Wait for a DOM element to be visible
:param selenium: selenium webdriver Instance
:param search_id: DOM element id to search for
:param wait_duration: time limit to be used in WebDriverWait()
"""
try:
return WebDriverWait(selenium, wait_duration).until(
ec.visibility_of_element_located((By.ID, search_id)))
except TimeoutException:
raise AssertionError(
"Element with id: {} was not visible within the {} second "
"wait period.".format(search_id, wait_duration))


def wait_until_class_visible(selenium, search_class, wait_duration):
"""
Wait for a DOM element to be visible
Expand All @@ -145,71 +47,3 @@ def wait_until_class_visible(selenium, search_class, wait_duration):
raise AssertionError(
"Element with class: '{}' was not visible within the {} second "
"wait period.".format(search_class, wait_duration))


def wait_until_id_located(selenium, search_id, wait_duration):
"""
Wait for a DOM element to be visible
:param selenium: selenium webdriver Instance
:param search_id: DOM element id to search for
:param wait_duration: time limit to be used in WebDriverWait()
"""
try:
return WebDriverWait(selenium, wait_duration).until(
ec.presence_of_element_located((By.ID, search_id))
)
except TimeoutException:
raise AssertionError(
"Element with id: '{}' was not located within the {} second "
"wait period.".format(search_id, wait_duration))


def delete_from_ui(selenium, object_name, total_objects):
"""
Delete some objects by interacting with Refinery's ui
:param selenium: selenium webdriver Instance
:param object_name: name of object to delete (dataset or analysis)
:param total_objects: number of objects that are to be deleted
"""
if object_name == "analysis":
object_name_plural = "analyses"
elif object_name == "dataset":
object_name_plural = "datasets"

# Delete until there are none left
while total_objects:
wait_until_class_visible(selenium, '{}-delete'.format(object_name),
MAX_WAIT)
selenium.find_elements_by_class_name('{}-delete'.format(object_name))[
0].click()
wait_until_id_visible(selenium, '{}-delete-button'.format(
object_name), MAX_WAIT)
wait_until_id_clickable(
selenium, '{}-delete-button'.format(object_name),
MAX_WAIT).click()
selenium.refresh()

total_objects -= 1

if object_name == "analysis":

if total_objects <= 1:
assert_text_within_id(
selenium,
"total-{}".format(object_name_plural),
MAX_WAIT,
"{} {}".format(total_objects, object_name))
else:
assert_text_within_id(
selenium,
"total-{}".format(object_name_plural),
MAX_WAIT,
"{} {}".format(total_objects, object_name_plural)
)
else:
assert_text_within_id(
selenium,
"total-{}".format(object_name_plural),
MAX_WAIT,
"{} data sets".format(total_objects)
)