Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rename() task and unnecessary code from rename_results() #2725

Merged
merged 1 commit into from Apr 23, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Apr 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #2725 into develop will decrease coverage by 0.65%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2725      +/-   ##
===========================================
- Coverage    56.48%   55.82%   -0.66%     
===========================================
  Files          398      398              
  Lines        25957    25402     -555     
  Branches      1239     1239              
===========================================
- Hits         14662    14181     -481     
+ Misses       11295    11221      -74
Impacted Files Coverage Δ
refinery/file_store/tasks.py 30% <ø> (-4.83%) ⬇️
refinery/core/models.py 73.04% <28.57%> (-4.26%) ⬇️
refinery/tool_manager/tasks.py 100% <0%> (ø) ⬆️
refinery/tool_manager/views.py 96.22% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cd3b3...0895ff7. Read the comment docs.

@hackdna hackdna merged commit 81c5878 into develop Apr 23, 2018
@hackdna hackdna deleted the hackdna/remove-rename-task branch April 23, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants