Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order event and tools by creation_time. #2769

Merged
merged 1 commit into from May 15, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented May 15, 2018

Ref #2768

@scottx611x Temp (hot) fix using the UI filtering. The better solution is to add the django-filter and order in the DRF serializer. Adding the dependency will take some coordination due to making it compatible with our other 'older' dependencies.

@jkmarx jkmarx self-assigned this May 15, 2018
@jkmarx jkmarx requested a review from scottx611x May 15, 2018 19:12
@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #2769 into release-1.6.4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-1.6.4    #2769   +/-   ##
==============================================
  Coverage          56.57%   56.57%           
==============================================
  Files                414      414           
  Lines              25780    25780           
  Branches            1253     1253           
==============================================
  Hits               14585    14585           
  Misses             11195    11195

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7036c...a5877da. Read the comment docs.

@scottx611x scottx611x merged commit 9ee0a5e into release-1.6.4 May 15, 2018
@scottx611x scottx611x deleted the jkmarx/order-events-tools-api branch May 15, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants