Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scottx611x/fix visualization launches #2775

Merged
merged 7 commits into from May 21, 2018

Conversation

scottx611x
Copy link
Member

Fixes #2774

…tNodes;

Since all of a DataSets Node information is passed along, its quite likely that there could be a Node with an invalid data file
@scottx611x scottx611x requested a review from hackdna May 18, 2018 19:36
@scottx611x scottx611x added this to To Do in Tool APIs via automation May 18, 2018
@scottx611x scottx611x moved this from To Do to Doing in Tool APIs May 18, 2018
@scottx611x scottx611x moved this from Doing to QC in Tool APIs May 18, 2018
@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #2775 into release-1.6.4 will decrease coverage by 2.32%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.6.4    #2775      +/-   ##
=================================================
- Coverage           58.9%   56.58%   -2.33%     
=================================================
  Files                414      414              
  Lines              28047    25783    -2264     
  Branches            1253     1253              
=================================================
- Hits               16522    14589    -1933     
+ Misses             11525    11194     -331
Impacted Files Coverage Δ
refinery/data_set_manager/tests.py 99.88% <100%> (-0.04%) ⬇️
refinery/tool_manager/models.py 96.97% <100%> (-0.89%) ⬇️
refinery/data_set_manager/utils.py 76.21% <100%> (-1.09%) ⬇️
refinery/core/models.py 72.91% <0%> (-4.7%) ⬇️
...ource/js/dashboard/controllers/dataset-deletion.js 13.88% <0%> (-3.76%) ⬇️
refinery/core/api.py 40.51% <0%> (-3.3%) ⬇️
refinery/data_set_manager/views.py 44.42% <0%> (-2.5%) ⬇️
refinery/core/tests.py 99.56% <0%> (-0.18%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40deb27...868f353. Read the comment docs.

…launch input Nodes;

Visualization Tools also send over information about all other Node's in a DataSet currently, but it shouldn't be the case that a RuntimeError is raised if a url can't be fetched for any of thoses Nodes that aren't explicitly part of a user's selected inputs
@scottx611x scottx611x requested review from jkmarx and removed request for hackdna May 21, 2018 14:26
@scottx611x scottx611x merged commit 37800a3 into release-1.6.4 May 21, 2018
Tool APIs automation moved this from QC to Done May 21, 2018
@scottx611x scottx611x deleted the scottx611x/fix-visualization-launches branch May 21, 2018 15:31
@scottx611x scottx611x added this to the Release 1.6.4 milestone May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tool APIs
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants