Jkmarx/ui tool launch input #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmarx
commented
Jun 4, 2018
| @@ -28,7 +28,8 @@ <h4 class="emphasized text-align-center m-t-1-5"> | |||
| <span ng-if="!tool.owner.full_name"> | |||
| {{ tool.owner.username }} | |||
| </span> | |||
| launched an analysis: {{ tool.name }} | |||
| launched an analysis: {{ tool.display_name }} <span ng-if="!tool | |||
There was a problem hiding this comment.
this should cover old vis/analysis tools w/o any display names
Codecov Report
@@ Coverage Diff @@
## develop #2804 +/- ##
===========================================
- Coverage 58.03% 57.03% -1.01%
===========================================
Files 419 417 -2
Lines 27190 26066 -1124
Branches 1272 1255 -17
===========================================
- Hits 15781 14867 -914
+ Misses 11409 11199 -210
Continue to review full report at Codecov.
|
scottx611x
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2545