Jkmarx/add primary group api #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2820 +/- ##
===========================================
- Coverage 61.3% 57.33% -3.97%
===========================================
Files 423 420 -3
Lines 30523 26474 -4049
Branches 1300 1258 -42
===========================================
- Hits 18711 15178 -3533
+ Misses 11811 11296 -515
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
scottx611x
requested changes
Jun 15, 2018
| @@ -1,19 +1,18 @@ | |||
| # -*- coding: utf-8 -*- | |||
| from __future__ import unicode_literals | |||
|
|
|||
| from django.db import models, migrations | |||
| from django.db import migrations | |||
| from django.utils import timezone | |||
|
|
|||
There was a problem hiding this comment.
Add from guardian.shortcuts import get_groups_with_perms
| @@ -22,7 +21,9 @@ def create_initial_site_statistics(apps, schema_editor): | |||
| [dataset for dataset in DataSet.objects.all() if dataset.shared] | |||
There was a problem hiding this comment.
get_groups_with_perms(dataset) instead of dataset.shared
There was a problem hiding this comment.
sorry, I forgot to push my update.
refinery/core/serializers.py
Outdated
| 'User is not a member of group, %s', group | ||
| ) | ||
|
|
||
| if group.name != 'Public': |
There was a problem hiding this comment.
settings.REFINERY_PUBLIC_GROUP_NAME
refinery/core/views.py
Outdated
|
|
||
|
|
||
| class UserProfileViewSet(APIView): | ||
| """API endpoint that allows for UserProfiles to be edits. |
refinery/core/views.py
Outdated
| http_method_names = ["patch"] | ||
|
|
||
| def patch(self, request, uuid): | ||
| if not request.user.is_anonymous(): |
There was a problem hiding this comment.
What about flipping the first ifs logic here:
def patch(self, request, uuid):
if request.user.is_anonymous():
return Response(
self.user, status=status.HTTP_401_UNAUTHORIZED
)
serializer = UserProfileSerializer(request.user.profile,
data=request.data,
partial=True,
context={'request': request})
if serializer.is_valid():
serializer.save()
return Response(
serializer.data, status=status.HTTP_202_ACCEPTED
)
return Response(
serializer.errors, status=status.HTTP_400_BAD_REQUEST
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-API to support user-profile updates, specifically the primary-group
Ref #2781