Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug related to how modal closes. #2856

Merged
merged 2 commits into from Jul 12, 2018
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jul 11, 2018

  • Bug in dashboard, the data set list did not refresh after transferring ownership

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #2856 into develop will decrease coverage by 0.19%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #2856     +/-   ##
=========================================
- Coverage    59.19%     59%   -0.2%     
=========================================
  Files          434     434             
  Lines        27313   27096    -217     
  Branches      1268    1266      -2     
=========================================
- Hits         16169   15989    -180     
+ Misses       11144   11107     -37
Impacted Files Coverage Δ
...ce/js/dashboard/controllers/data-sets-card-ctrl.js 67.64% <25%> (-0.39%) ⬇️
refinery/core/views.py 40.34% <0%> (-6.97%) ⬇️
refinery/core/serializers.py 80.45% <0%> (-5.72%) ⬇️
refinery/data_set_manager/tasks.py 44.58% <0%> (-1.63%) ⬇️
refinery/data_set_manager/search_indexes.py 96.26% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e607392...4b6d507. Read the comment docs.

@jkmarx jkmarx requested a review from scottx611x July 12, 2018 16:06
@jkmarx jkmarx self-assigned this Jul 12, 2018
@jkmarx jkmarx added this to the Release 1.6.5 milestone Jul 12, 2018
@jkmarx jkmarx merged commit e39c04e into develop Jul 12, 2018
@jkmarx jkmarx deleted the jkmarx/data-set-refresh-bug branch July 12, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants