Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/fix bug event refresh #2868

Merged
merged 4 commits into from Jul 17, 2018
Merged

Jkmarx/fix bug event refresh #2868

merged 4 commits into from Jul 17, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jul 17, 2018

  • Fixes bug: Events list refreshes after data sets transfer or deleted.

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #2868 into develop will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2868      +/-   ##
===========================================
- Coverage    59.03%   59.01%   -0.03%     
===========================================
  Files          434      434              
  Lines        27151    27118      -33     
  Branches      1271     1268       -3     
===========================================
- Hits         16029    16004      -25     
+ Misses       11122    11114       -8
Impacted Files Coverage Δ
.../ui/source/js/dashboard/directives/history-card.js 100% <ø> (ø) ⬆️
...ce/js/dashboard/controllers/data-sets-card-ctrl.js 66.34% <0%> (-0.33%) ⬇️
...ce/js/dashboard/controllers/dashboard-main-ctrl.js 95.83% <100%> (-0.72%) ⬇️
...urce/js/dashboard/controllers/history-card-ctrl.js 92% <77.77%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be85c39...0996013. Read the comment docs.

@jkmarx jkmarx requested a review from scottx611x July 17, 2018 15:12
@jkmarx jkmarx self-assigned this Jul 17, 2018
@jkmarx jkmarx merged commit b6ea673 into develop Jul 17, 2018
@jkmarx jkmarx deleted the jkmarx/fix-bug-event-refresh branch July 17, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants