Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking ownership by user perms not group. #2886

Merged
merged 4 commits into from Jul 18, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jul 18, 2018

Ref #2875

*Note, issues with cached data sets in the launch pad (uses api v1).

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #2886 into release-1.6.5 will decrease coverage by 0.15%.
The diff coverage is 55.55%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.6.5    #2886      +/-   ##
=================================================
- Coverage          59.16%   59.01%   -0.16%     
=================================================
  Files                434      434              
  Lines              27722    27121     -601     
  Branches            1268     1268              
=================================================
- Hits               16403    16006     -397     
+ Misses             11319    11115     -204
Impacted Files Coverage Δ
refinery/core/api.py 40.65% <0%> (-2.63%) ⬇️
refinery/core/views.py 40.48% <58.82%> (+0.13%) ⬆️
refinery/tool_manager/models.py 97.01% <0%> (-0.21%) ⬇️
refinery/tool_manager/tests.py 99.82% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d020f...dd6f501. Read the comment docs.

@jkmarx jkmarx requested a review from scottx611x July 18, 2018 16:58
@jkmarx jkmarx self-assigned this Jul 18, 2018
@jkmarx jkmarx added this to the Release 1.6.5 milestone Jul 18, 2018
@jkmarx jkmarx merged commit 2e3e00d into release-1.6.5 Jul 18, 2018
@jkmarx jkmarx deleted the jkmarx/fix-ui-update-after-transfer branch July 18, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants