Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jkmarx/node api v2 unit test #2913

Merged
merged 11 commits into from Jul 30, 2018
Merged

Jkmarx/node api v2 unit test #2913

merged 11 commits into from Jul 30, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jul 30, 2018 •
edited

  • Add unit tests for node v2 api - patch

@jkmarx jkmarx added this to the Release 1.6.6 milestone Jul 30, 2018
@jkmarx jkmarx self-assigned this Jul 30, 2018
@jkmarx jkmarx requested a review from scottx611x July 30, 2018 17:21
@codecov
Copy link

codecov bot commented Jul 30, 2018 •
edited

Codecov Report

Merging #2913 into develop will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2913      +/-   ##
===========================================
- Coverage    59.38%   59.32%   -0.06%     
===========================================
  Files          435      435              
  Lines        27321    27259      -62     
  Branches      1273     1273              
===========================================
- Hits         16224    16172      -52     
+ Misses       11097    11087      -10
Impacted Files Coverage Δ
...js/file-browser/ctrls/data-file-edit-modal-ctrl.js 67.64% <ø> (ø) ⬆️
refinery/data_set_manager/views.py 60.2% <100%> (+0.75%) ⬆️
refinery/data_set_manager/test_views.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8144c...f90d80d. Read the comment docs.

scottx611x
scottx611x reviewed Jul 30, 2018
View reviewed changes
Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question is if it would be better to still send { file_uuid: null } from the client instead of ''?

refinery/data_set_manager/test_views.py Outdated
@@ -1,5 +1,6 @@
import mock
import uuid
from urlparse import urljoin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical import ordering

@jkmarx
Copy link
Member Author

jkmarx commented Jul 30, 2018

@scottx611x No, empty string is fine. I want to be explicit and avoid the null conversion.

@jkmarx jkmarx merged commit ab9c8aa into develop Jul 30, 2018
jkmarx added a commit that referenced this pull request Jul 30, 2018
@jkmarx
Refactor unit tests. (#2914)
52601f6 
* Refactor unit tests.

* Fix imports.

* Jkmarx/node api v2 unit test (#2913)

* Move node related to data_set_manager app

* Move node v1 api to data_set_manager.

* Update api v1 url dependency.

* Move node v1 api tests to correct directory.

* Remove unused get.

* Add unit tests.

* Add unit tests and add more responses to api.

* Update client call.

* Update text.

* Fix import order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottx611x scottx611x scottx611x left review comments

Assignees

@jkmarx jkmarx

Labels
None yet
Projects
None yet
Milestone
Release 1.6.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkmarx @scottx611x