Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count failed Analyses against a Dataset's cleanliness #2920

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

scottx611x
Copy link
Member

Towards #2896
Ref: #2896 (comment)

@scottx611x scottx611x added this to the Release 1.6.6 milestone Aug 1, 2018
@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #2920 into develop will decrease coverage by 0.95%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2920      +/-   ##
===========================================
- Coverage    60.34%   59.38%   -0.96%     
===========================================
  Files          435      435              
  Lines        28215    27295     -920     
  Branches      1283     1273      -10     
===========================================
- Hits         17025    16208     -817     
+ Misses       11190    11087     -103
Impacted Files Coverage Δ
refinery/core/tests.py 99.73% <100%> (-0.15%) ⬇️
refinery/core/models.py 76.1% <100%> (-1.22%) ⬇️
refinery/core/views.py 42.36% <0%> (-5.24%) ⬇️
...ce/js/dashboard/controllers/data-sets-card-ctrl.js 66.34% <0%> (-4.45%) ⬇️
refinery/data_set_manager/api.py 95.37% <0%> (-2.69%) ⬇️
...ce/js/commons/ctrls/group-member-add-modal-ctrl.js 54.28% <0%> (-2.48%) ⬇️
...nery/ui/source/js/commons/services/data-sets-v2.js 100% <0%> (ø) ⬆️
...rce/js/dashboard/services/data-set-card-factory.js 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527cc10...7a3dcc2. Read the comment docs.

@scottx611x scottx611x requested a review from jkmarx August 1, 2018 15:32
Copy link
Member

@jkmarx jkmarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has_passing_analyses? It's fine though. I couldn't think of anything better.

:return: boolean
"""
return not (self.get_analyses() or self.has_visualizations())
has_non_failed_analyses = any(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has_passing_analyses? This is fine though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thought about something like that but that wouldn't reflect on any analyses that are currently running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants