-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't count failed Analyses against a Dataset's cleanliness #2920
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2920 +/- ##
===========================================
- Coverage 60.34% 59.38% -0.96%
===========================================
Files 435 435
Lines 28215 27295 -920
Branches 1283 1273 -10
===========================================
- Hits 17025 16208 -817
+ Misses 11190 11087 -103
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has_passing_analyses? It's fine though. I couldn't think of anything better.
:return: boolean | ||
""" | ||
return not (self.get_analyses() or self.has_visualizations()) | ||
has_non_failed_analyses = any( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has_passing_analyses? This is fine though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thought about something like that but that wouldn't reflect on any analyses that are currently running
Towards #2896
Ref: #2896 (comment)